fix: folder tree selection after any action in main content by mykh-hailo · Pull Request #59359 · nextcloud/server

mykh-hailo · 2026-03-31T17:06:37Z

Resolves: Folder tree view: Selected folder in left sidebar is deselected after any action in main window, causing loss of user context #59171

Summary

his PR improves UI behavior and layout consistency in file navigation.
It fixes incorrect selection behavior in the Files left sidebar for folder-tree entries.

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

The content of this PR was partly or fully generated using AI

skjnldsv · 2026-04-01T06:37:14Z

+const isFolderTreeNode = computed(() => props.view.id.startsWith(`${folderTreeId}::`))
+const isDirectoryActive = computed(() => {
+	if (!isFolderTreeNode.value) {
+		return false
+	}
+
+	const currentView = String(route.params?.view ?? '')
+	const currentDir = normalizeDir(route.query?.dir)
+	const viewDir = normalizeDir(props.view.params?.dir)
+
+	return currentView === folderTreeId && currentDir === viewDir
+})


Can't really say I'm happy to see custom view code into a global component, but I don't really see a better way, that's correct yeah 🤔

@susnux , any opinions ?

Seems like a router issue / design problem.
Because the URL is bound to active file not active folder (/files/ACTIVEFILE?dir=ACTIVEFOLDER vs /files/ACTIVEFOLDER?file=ACTIVEFILE)

So this happens because we se the to of the view to /files/FOLDERID right?
Does it work if we instead just use "additional params" and use the dir param?

@susnux I update some codes to make tree view selection works properly as expected.
For a technical overview, I have the FolderNavigationListItem to be active according to dir parameter of the route.
I'd appreciate it if you review and share any opinion on it.

mykh-hailo · 2026-04-07T13:38:51Z

@susnux I updated the code with the latest master branch.
I'd appreciate it if you check it please.

mykh-hailo · 2026-04-08T06:47:20Z

@susnux , @skjnldsv
I'd appreciate it if you provide any updates on this PR.

mykh-hailo · 2026-04-09T13:42:23Z

@skjnldsv , @susnux , @sorbaugh , @nfebe
Could you provide me any updates on this PR please?

mykh-hailo · 2026-04-13T06:08:27Z

@artonge I'd appreciate it if you have any change to review this PR and leaves some feedback.

cc @susnux , @skjnldsv , @sorbaugh , @nfebe

github-actions · 2026-04-15T02:14:25Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

mykh-hailo · 2026-05-04T05:26:13Z

@susnux can you review this PR please?

susnux

seems to fix the issue, thank you!

mykh-hailo · 2026-05-08T04:01:49Z

@susnux can you provide me any updates please?

mykh-hailo · 2026-05-11T19:39:29Z

@nfebe , @skjnldsv , @szaimen
Can anyone provide me updates on this PR?

szaimen

🐘

mykh-hailo · 2026-05-12T16:55:25Z

@szaimen , as far as I checked the test fails, they are not related to mine.
Looks like there are some problems on the cypress test.
Can you check it please to merge my PR?

mykh-hailo · 2026-05-15T05:04:36Z

@szaimen can you provide me any updates on this PR please?

Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>

mykh-hailo · 2026-05-15T07:31:58Z

@szaimen the test fails again which is not related to mine.
My update is only to update the left sidebar of the selected folder.
No relation to file download, rename, copy/move, favorite.

szaimen · 2026-05-15T07:42:50Z

@susnux can you please help @mykh-hailo to move the PR forward?

mykh-hailo · 2026-05-15T16:29:01Z

@susnux can you help me to move this PR forward?
The test failure is not related to mine.
I also can see that your PR also fails.
I think the cypress test result is not stable.

mykh-hailo · 2026-05-15T17:43:11Z

@susnux , the test is again failed.
can you check again please?

susnux · 2026-05-16T08:15:07Z

/backport to stable34

susnux · 2026-05-16T08:15:23Z

/backport to stable33

susnux · 2026-05-16T08:15:37Z

@mykh-hailo thank you very much for your contribution!

mykh-hailo requested review from a team and skjnldsv as code owners March 31, 2026 17:06

mykh-hailo requested review from nfebe and sorbaugh and removed request for a team March 31, 2026 17:06

skjnldsv reviewed Apr 1, 2026

View reviewed changes

skjnldsv requested a review from susnux April 1, 2026 06:37

skjnldsv added bug 3. to review Waiting for reviews feature: files labels Apr 1, 2026

skjnldsv added this to the Nextcloud 34 milestone Apr 1, 2026

mykh-hailo force-pushed the fix/folder-tree-view-selection branch from 86139a8 to 8306091 Compare April 6, 2026 04:34

susnux added the team: Files Code maintained by 📁 Files team label Apr 6, 2026

mykh-hailo force-pushed the fix/folder-tree-view-selection branch 2 times, most recently from 8e5c85f to a7172a3 Compare April 7, 2026 13:38

mykh-hailo force-pushed the fix/folder-tree-view-selection branch 3 times, most recently from aaf8ec9 to f7243b8 Compare April 7, 2026 16:03

mykh-hailo force-pushed the fix/folder-tree-view-selection branch 2 times, most recently from a43ee10 to be24676 Compare April 9, 2026 09:38

mykh-hailo requested a review from skjnldsv April 9, 2026 10:00

mykh-hailo force-pushed the fix/folder-tree-view-selection branch from be24676 to 69fe46e Compare April 9, 2026 14:03

mykh-hailo mentioned this pull request Apr 9, 2026

feat: remove password column from user table #59348

Merged

7 tasks

mykh-hailo force-pushed the fix/folder-tree-view-selection branch from 69fe46e to 7cc4c09 Compare April 13, 2026 06:07

mykh-hailo force-pushed the fix/folder-tree-view-selection branch from 7cc4c09 to 339d4f9 Compare April 13, 2026 19:49

mykh-hailo requested a review from susnux May 4, 2026 05:18

mykh-hailo force-pushed the fix/folder-tree-view-selection branch from f1b4dc7 to 9c6022f Compare May 5, 2026 10:50

susnux approved these changes May 5, 2026

View reviewed changes

mykh-hailo force-pushed the fix/folder-tree-view-selection branch from 9c6022f to 6e43d40 Compare May 6, 2026 02:53

mykh-hailo requested a review from susnux May 8, 2026 04:01

mykh-hailo force-pushed the fix/folder-tree-view-selection branch from 6e43d40 to 4fb13de Compare May 11, 2026 19:38

szaimen approved these changes May 12, 2026

View reviewed changes

szaimen enabled auto-merge May 12, 2026 12:01

fix: folder tree selection after any action in main content

5380fd6

Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>

szaimen force-pushed the fix/folder-tree-view-selection branch from 4fb13de to 5380fd6 Compare May 15, 2026 07:13

susnux approved these changes May 15, 2026

View reviewed changes

susnux modified the milestones: Nextcloud 34, Nextcloud 35 May 16, 2026

szaimen merged commit f188efd into nextcloud:master May 16, 2026
150 of 157 checks passed

backportbot Bot added the backport-request label May 16, 2026

backportbot Bot mentioned this pull request May 16, 2026

[stable34] fix: folder tree selection after any action in main content #60478

Open

backportbot Bot removed the backport-request label May 16, 2026

backportbot Bot mentioned this pull request May 16, 2026

[stable33] fix: folder tree selection after any action in main content #60479

Draft

3 tasks

Uh oh!

Conversation

mykh-hailo commented Mar 31, 2026 • edited by susnux Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

AI (if applicable)

Uh oh!

skjnldsv Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

skjnldsv Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

susnux Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

mykh-hailo Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mykh-hailo commented Apr 7, 2026

Uh oh!

mykh-hailo commented Apr 8, 2026

Uh oh!

mykh-hailo commented Apr 9, 2026

Uh oh!

mykh-hailo commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

mykh-hailo commented May 4, 2026

Uh oh!

susnux left a comment

Choose a reason for hiding this comment

Uh oh!

mykh-hailo commented May 8, 2026

Uh oh!

mykh-hailo commented May 11, 2026

Uh oh!

szaimen left a comment

Choose a reason for hiding this comment

Uh oh!

mykh-hailo commented May 12, 2026

Uh oh!

mykh-hailo commented May 15, 2026

Uh oh!

mykh-hailo commented May 15, 2026

Uh oh!

szaimen commented May 15, 2026

Uh oh!

mykh-hailo commented May 15, 2026

Uh oh!

mykh-hailo commented May 15, 2026

Uh oh!

Uh oh!

susnux commented May 16, 2026

Uh oh!

susnux commented May 16, 2026

Uh oh!

susnux commented May 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mykh-hailo commented Mar 31, 2026 •

edited by susnux

Loading

mykh-hailo Apr 6, 2026 •

edited

Loading

mykh-hailo commented Apr 13, 2026 •

edited

Loading